improbable-eng / ansible-buildkite-agent

An Ansible role to install the Buildkite Agent.
Apache License 2.0
12 stars 14 forks source link

Introduce Windows support #6

Closed petemounce closed 6 years ago

petemounce commented 6 years ago

Tested against Windows 2016 only (reports as "10" to distribution_major_version)

Things:

Part of #5.

petemounce commented 6 years ago

@hectcastro I think this is now ready for review. I've been using it successfully across both Linux and Windows.

hectcastro commented 6 years ago

Thanks for the contribution, @petemounce. Can you please rebase your commit history down a bit before we merge?

petemounce commented 6 years ago

Sure; or, you could squash merge directly if the repository has that set up?

https://help.github.com/articles/about-pull-request-merges/ describes what happens and I think the repository default settings have it turned on.