search

improbable-eng / etcd-cluster-operator

A controller to deploy and manage etcd clusters inside of Kubernetes
MIT License
129 stars 35 forks source link

Fix broken release image build due to shell invocation #131

Closed cheahjs closed 4 years ago

cheahjs commented 4 years ago

Changes

Fixes #126. Introduces two different stages release and debug that can be selected with docker build --target.

Building a debug image involves building a release image and throwing it away. Side benefit is that building a debug image at least verifies that a release image can be built. Not sure how to get around this without resorting to two different Dockerfiles.

Verification

Ran make docker-build && make docker-build-debug