Various changes to make it easier to run e2e tests in non-kind clusters - Githubissues

improbable-eng / etcd-cluster-operator

A controller to deploy and manage etcd clusters inside of Kubernetes

MIT License

128 stars 35 forks source link

Various changes to make it easier to run e2e tests in non-kind clusters #164

Closed wallrj closed 4 years ago

wallrj commented 4 years ago

Add a dockerignore file, to avoid copying all the binaries to minikube
- Add new make targets to allow me to install everything easily on minikube
- Update e2e test script to re-use the make targets where possible, this means we're actually testing the make deploy and make install targets in CI.
- Remove the use of etcd client API in the e2e tests. Instead use an in-cluster etcdctl command.
- Required a smaller cluster size in the scale-up test because the circle ci machine / node was running out of CPU resource for the extra in-cluster etcdctl pod
- Tidy up the docker image names in the makefile and always include the docker repo

With this in place, I can now run:

$ minikube start --cpus=4 --memory=4000mb
$ eval $(minikube docker-env)
$ make e2e

This should also make it easier to migrate to kind 0.7 which updates the current KUBECTL context (like minikube does)

And it should make it easier to run the tests against e.g. GKE clusters too.

wallrj commented 4 years ago

@cheahjs Please take a look at this PR if you have a moment.