improbable-eng / etcd-cluster-operator

A controller to deploy and manage etcd clusters inside of Kubernetes
MIT License
128 stars 35 forks source link

Create end-to-end tests for scheduled backups #181

Open wallrj opened 4 years ago

wallrj commented 4 years ago

In #165 I found that the scheduled backup mechanism was broken. The kubebuilder tests use a fake cronhandler which executes jobs immediately. In the actual implementation, we had forgotten to start the cron handler and we'd forgotten to create RBAC roles to allow the etcdbackupschedule_controller to create etcdbackup resources.