search

improbable-eng / etcd-cluster-operator

A controller to deploy and manage etcd clusters inside of Kubernetes
MIT License
128 stars 35 forks source link

.*: TLS and Etcd v3 support #195

Closed FlorinPeter closed 2 years ago

FlorinPeter commented 3 years ago

First of all thx for this awesome etcd operator ❤️ and sorry for this huge update. I started first to add tls support and ended later on by adding support vor etcd v3 api that allows to run the latest etcd v3.4.x versions. My focus was on keeping the changes as minimum as possible and to maintain compatibility with etcd v2.

Changes

Verification

Deploy a cluster like:

apiVersion: etcd.improbable.io/v1alpha1
kind: EtcdCluster
metadata:
  name: my-cluster
spec:
  replicas: 3
  version: 3.4.13
  tls:
    enabled: true
  storage:
    volumeClaimTemplate:
      storageClassName: standard
      resources:
        requests:
          storage: 1Mi
  podTemplate:
    resources:
      requests:
        cpu: 200m
        memory: 200Mi
      limits:
        cpu: 200m
        memory: 200Mi
    affinity:
      podAntiAffinity:
        preferredDuringSchedulingIgnoredDuringExecution:
          - weight: 100
            podAffinityTerm:
              labelSelector:
                matchExpressions:
                  - key: etcd.improbable.io/cluster-name
                    operator: In
                    values:
                      - my-cluster
              topologyKey: kubernetes.io/hostname
improbable-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/improbable-eng/etcd-cluster-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
FlorinPeter commented 3 years ago

@cheahjs thx for having a look on this PR. I will take care of your comments around mid of January.

cheahjs commented 3 years ago

@FlorinPeter hey, any updates?

FlorinPeter commented 3 years ago

@cheahjs worked on some stuff, I hope to make progress in the next week, sorry for the delay.

gottwald commented 3 years ago

@FlorinPeter @cheahjs Any updates on this? Anything I could maybe help you with?

gottwald commented 3 years ago

@FlorinPeter Would you mind if I carry this PR further?

FlorinPeter commented 2 years ago

@FlorinPeter Would you mind if I carry this PR further?

@gottwald sure please go ahead as I have no time to work on that at the moment.