search

improbable-eng / grpc-web

gRPC Web implementation for Golang and TypeScript
Apache License 2.0
4.39k stars 435 forks source link

Bump nhooyr.io/websocket #1182

Open alexpyc opened 3 months ago

alexpyc commented 3 months ago

Versions of relevant software used

0.15.0

What happened

The captioned module removed releases of v1.8.6 from GitHub: https://github.com/nhooyr/websocket-old/tags

What you expected to happen

Successful go mod vendor

How to reproduce it (as minimally and precisely as possible):

go mod vendor in a project that imports this repository (grpcweb)

Full logs to relevant components

go: downloading nhooyr.io/websocket v1.8.6
go: github.com/improbable-eng/grpc-web@v0.15.0 requires
    nhooyr.io/websocket@v1.8.6: reading nhooyr.io/websocket/go.mod at revision v1.8.6: unknown revision v1.8.6

Anything else we need to know

farisekananda commented 3 months ago

not using grpc-web, but also have the same error. You need to replace nhooyr.io/websocket with github.com/coder/websocket as the old project has been deprecated and moved to Coder (ref: https://coder.com/blog/websocket) sample replace:

replace nhooyr.io/websocket => github.com/coder/websocket v1.8.7
iamwhil commented 2 months ago

Oh, hello there. Arriving from a botched go build with alpaca 1.9.0 as a dependency. farisekananda's solution works.