improbable-eng / grpc-web

gRPC Web implementation for Golang and TypeScript
Apache License 2.0
4.38k stars 436 forks source link

Re-enable the sending of pre-announcement trailers #300

Open johanbrandhorst opened 5 years ago

johanbrandhorst commented 5 years ago

Sometime between 1.9.2 and 1.18.0 the gRPC Go client started including the pre-announcement trailer headers in the header values read by the client. We should aim to provide the same experience, so I think we should turn on sending these. Specifically, it would mean removing the following lines from the proxy:

I briefly tested simply removing these lines and running some tests but it appears the client is blocking on something, and I haven't yet had the time to investigate where.

johanbrandhorst commented 5 years ago

See https://github.com/improbable-eng/js-browser-headers/issues/21 also.

johanbrandhorst commented 5 years ago

Still investigating this