search

improbable-eng / grpc-web

gRPC Web implementation for Golang and TypeScript
Apache License 2.0
4.38k stars 436 forks source link

gRPC requires a ResponseWriter supporting http.CloseNotifier #638

Open joeyorlando opened 4 years ago

joeyorlando commented 4 years ago

Versions of relevant software used

What happened Following the react-typescript + golang grpcweb example from this repo exactly, I was seeing HTTP 500s in the browser. The only thing I would see in the response would be "gRPC requires a ResponseWriter supporting http.CloseNotifier".

Googling this error code didn't lead me to anything useful. The one thing I did notice that fixed my problem, was that your example code had last been edited on April 11th 2019. I bumped down my version of improbable-eng/grpc-web to 0.9.1 (released in Feb 2019) and voila, problem solved.

I have no clue as to what could be causing this but I just wanted to post this in case anyone else was running into the same issue with the example.

johanbrandhorst commented 4 years ago

I wonder if https://github.com/improbable-eng/grpc-web/commit/2049acb57d304a04c1cd4be6baadb897812f98ef broke this. Could you try on a build before this commit?

joeyorlando commented 4 years ago

I will give this a try this evening and let you know!

On Wed, Jan 15, 2020 at 08:25 Johan Brandhorst notifications@github.com wrote:

I wonder if 2049acb https://github.com/improbable-eng/grpc-web/commit/2049acb57d304a04c1cd4be6baadb897812f98ef broke this. Could you try on a build before this commit?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/improbable-eng/grpc-web/issues/638?email_source=notifications&email_token=ACHYTLY2QSMC3RWTWZXNWC3Q5Z3JTA5CNFSM4KG4RSD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI64ALA#issuecomment-574472236, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHYTL5XGTHF42PWUCNWDFLQ5Z3JTANCNFSM4KG4RSDQ .

-- Joey Orlando

Phone | (514) 632-1003 E-mail | joseph.t.orlando@gmail.com

bakins commented 4 years ago

Could be related to this in grpc https://github.com/grpc/grpc-go/pull/2697 If you update grpc dependency, does it still error?