improbable-eng / js-browser-headers

Compatibility Layer for the Headers class
Apache License 2.0
12 stars 9 forks source link

fix(util): Explicitly check for undefined value in getHeaderValues #23

Closed gurkohli closed 2 years ago

gurkohli commented 2 years ago

Fix for https://github.com/improbable-eng/grpc-web/issues/1109

getHeaderValues does a truthy check with the value that is returned by headers.get

  const getValue = headers.get(key);
  if (getValue && typeof getValue === "string") {

If getValue is an empty string, it fails this check. The empty string is returned by the function and the logic throws an error when .forEach is done on it. Fix is to correctly verify for non existence of the value and return an empty array in that case

Changes

Updated getHeaderValue to first check for the existence using headers.has. If the value does not exist, return empty array. Removed the truthy check afterwords

Verification

Tested by creating a build, using that build in @improbable/grpc-web client and further using that. The issue https://github.com/improbable-eng/grpc-web/issues/1109 goes away

gurkohli commented 2 years ago

Would you be able to review this or know the best person to review this @MarcusLongmuir ?