search

improbable-eng / phtree-cpp

PH-Tree C++ implementation by Improbable.
Apache License 2.0
22 stars 15 forks source link

.*: Use <limits> instead of <climits> #15

Closed ctbur closed 2 years ago

ctbur commented 2 years ago

Changes

Replaced include <climits> with include<limits> in all files. It was necessary to replace it in phtree/common/base_types.h to get the project to build on Linux with either GCC 11 or Clang 13. Other files were changed for consistency.

Compile error without the change: compile-error.log

Verification

Only built in on my machine.

improbable-til commented 2 years ago

Hi Cyrill, Improbable requires a CLA to be signed (see here). Could you provide us with an email address for contact?

improbable-til commented 2 years ago

I couldn't reproduce the problem with GCC 9, GCC 10, CLANG 9, CLANG 10, CLANG 11 or CLANG 12 on Ubuntu 20.04. But I accept that <limits> is generally preferable to <climits>. I am currently testing this a bit more with MSVC.

improbable-til commented 2 years ago

Thanks for contributing! :-)