improbable-eng / ts-protoc-gen

Protocol Buffers Compiler (protoc) plugin for TypeScript and gRPC-Web.
Apache License 2.0
1.36k stars 173 forks source link

update client stream to receive and return server response #231

Closed asutula closed 4 years ago

asutula commented 4 years ago

It is typical for grpc client streams to receive a final response from the server after ending the client stream. This wasn't implemented in ts-protoc-gen as described and exemplified in https://github.com/improbable-eng/ts-protoc-gen/issues/105. This PR fixes that.

Changes

Verification

Added a test in the client streaming tests that specifies the mock grpc transport return a message, and verifies that message was received.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.