Fix get/set conflicting method names.

pkwarren commented 3 years ago

Update the typescript generator to add a suffix '$' to methods which conflict on the Message base class ('getExtension'/'setExtension'/'getJsPbMessageId'/'setJsPbMessageId'). This will keep the typescript definitions in sync with the generated JS code from the protoc compiler.

Fixes #271.

Changes

Added example getter_name.proto which demonstrates conflicts with both string and bytes types.
Added integration test verifying the generated code.
Added suffix '$' on getter/setter methods.

Verification

Ran 'npm run test' to ensure test passed.
Verified that the typescript compiler didn't show any warnings about method conflicts in generated *.d.ts files.

pkwarren commented 3 years ago

/assign @easycz

pkwarren commented 3 years ago

@MarcusLongmuir - Is there any additional steps I should follow for PR reviews or is assigning @easyCZ still the correct process?

improbable-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarcusLongmuir, moadz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/improbable-eng/ts-protoc-gen/blob/master/OWNERS)~~ [MarcusLongmuir,moadz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

improbable-eng / ts-protoc-gen

Fix get/set conflicting method names. #272

Changes

Verification