Add support for proto3 optional presence

improbable-eng / ts-protoc-gen

Protocol Buffers Compiler (protoc) plugin for TypeScript and gRPC-Web.

Apache License 2.0

1.36k stars 173 forks source link

Add support for proto3 optional presence #275

Closed awbraunstein closed 3 years ago

awbraunstein commented 3 years ago

Changes

Add implementation for proto3 optional fields with presence tracking. Spec: https://github.com/protocolbuffers/protobuf/blob/master/docs/implementing_proto3_presence.md

Fixes: https://github.com/improbable-eng/ts-protoc-gen/issues/263

Additionally, this change:

Improves tests for the proto2 scalar messages
Explicitly calls .buffer on the serialized message before passing into Buffer.from to handle a weird typescript issue.

Verification

Tested via unit tests and visual inspection of generated files.

awbraunstein commented 3 years ago

@MarcusLongmuir would appreciate a review on this. Thanks.

MarcusLongmuir commented 3 years ago

Thanks for raising this @awbraunstein. @moadz is currently reviewing this. Will try to cut a release for this soon after it lands.

improbable-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: moadz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/improbable-eng/ts-protoc-gen/blob/master/OWNERS)~~ [moadz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

stof commented 3 years ago

@MarcusLongmuir any chance to make a release containing this feature ?

protoc 3.15.0 ships with it as a non-experimental feature.