Change return type of generated setters to the message type

improbable-eng / ts-protoc-gen

Protocol Buffers Compiler (protoc) plugin for TypeScript and gRPC-Web.

Apache License 2.0

1.36k stars 173 forks source link

Change return type of generated setters to the message type #281

Open craigatron opened 3 years ago

craigatron commented 3 years ago

Changes

message.ts - changed return type of generated setters to ${messageName}
ran npm run generate to regenerate example proto generated code
added tests that chain setter calls and verify value on generated object

Verification

Added unit tests for chained setter methods.

gecko655 commented 3 years ago

This fix is seriously important for the ts-protoc-gen users (and me). It seems that fixes and tests are good enough (for me). Would it be possible for the maintainers to review again?

Note: This PR fixes #218 #285 .

Update: This PR also fixes #289

improbable-prow-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarcusLongmuir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/improbable-eng/ts-protoc-gen/blob/master/OWNERS)~~ [MarcusLongmuir] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

chris-codaio commented 2 years ago

Just ran into this issue trying to update definitions. It looks like this PR is approved - any reason it can't be checked in and pushed out in a new version? Anything I can do to help?

thompsonja commented 2 years ago

Bumping this PR... is there any reason this can't be merged?

gonzojive commented 2 years ago

bump