Open craigatron opened 3 years ago
This fix is seriously important for the ts-protoc-gen users (and me). It seems that fixes and tests are good enough (for me). Would it be possible for the maintainers to review again?
Note: This PR fixes #218 #285 .
Update: This PR also fixes #289
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: MarcusLongmuir
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Just ran into this issue trying to update definitions. It looks like this PR is approved - any reason it can't be checked in and pushed out in a new version? Anything I can do to help?
Bumping this PR... is there any reason this can't be merged?
bump
Changes
npm run generate
to regenerate example proto generated codeVerification
Added unit tests for chained setter methods.