improbable-eng / ts-protoc-gen

Protocol Buffers Compiler (protoc) plugin for TypeScript and gRPC-Web.
Apache License 2.0
1.36k stars 173 forks source link

generated output omits the override modifier #317

Open NoNotNow opened 3 months ago

NoNotNow commented 3 months ago

Bug Report

Protoc-Gen-TS Version: 0.8.0 (example version, replace with the actual version)

Environment:

protoc-gen-ts@0.8.7

Description of the Problem: When compiling the generated output with the provided environment, the TypeScript compiler throws an error due to missing override modifiers on methods that override members in the base class.

Error Message:

TS4114: This member must have an 'override' modifier because it overrides a member in the base class 'Message'.

Generated output: static deserializeBinary(bytes: Uint8Array): ClientCode

Expected output: static override deserializeBinary(bytes: Uint8Array): ClientCode