impronunciable / hackdash

Ideas for a hackathon
http://hackdash.org
MIT License
68 stars 61 forks source link

Site is in Spanish if browser prefers German (Accept-Language) #156

Closed fnorf closed 7 years ago

fnorf commented 7 years ago

If you visit https://hackdash.org/ with a browser that prefers German (de) in its Accept-Language header the site will be shown in Spanish. It should fall back on English if German is not available ;)

You can check the language your browser prefers on https://ajaxhttpheaders2.appspot.com/?callback=wtf

impronunciable commented 7 years ago

@fnorf this is a bug, it should default to english. Thanks for pointing out!

impronunciable commented 7 years ago

@pjnovas where can we change this default?

montogeek commented 7 years ago

https://support.google.com/chromebook/answer/1059490?hl=en

impronunciable commented 7 years ago

@montogeek the issue is that if we don't support a language we should fallback to english, not spanish. Am I missing something from your link?

montogeek commented 7 years ago

Sorry, it thought about the browser config

pjnovas commented 7 years ago

@impronunciable hey!, that's weird the default is being get from here it should be falling back to EN

pjnovas commented 7 years ago

@impronunciable oh I saw it!, it should be changed HERE, sorry!

impronunciable commented 7 years ago

Making the change

impronunciable commented 7 years ago

@pjnovas changed it @fnorf does it work for you now?

fnorf commented 7 years ago

Thanks for the quick fix!