search

improvedk / OrcaMDF

A C# parser for MDF files. Allows you to read tables, metadata and indexes from MDF files without it being attached to a running SQL Server instance.
http://improve.dk/archive/2011/05/03/introducing-orcamdf.aspx
GNU General Public License v3.0
181 stars 74 forks source link

Ignore Sql Compression tests when the feature is not available #13

Closed zippy1981 closed 11 years ago

zippy1981 commented 11 years ago

I think it would be better if a test was ignored and not failed (yellow not red) when it could not be performed due to SQL not being available or supporting a feature. Here is an example of me ignoring the compression tests versions of 2008R2 that don't support them. I'll need to refactor it to work when the tests are run against multiple database versions, but what do you think of the idea?

improvedk commented 11 years ago

I'm not sure I understand the need for the SupportsCompression() check. The tests are already marked to only be run for 2008+ instances, thus not hitting 2005. Running the tests will require you to have a Developer/Enterprise edition SQL Server running locally, but I think that's a fair requirement (and it will go away when the tests are changed into static .MDFs being embedded). For now I'd much rather have the tests fail if you don't have the proper environment, rather than having them being ignored.

zippy1981 commented 11 years ago

If the MDFs will be included then the point is moot. I guess its fair to expect a person to have developer edition at least. Its a $50 license. Personally I have an MSDN subscription, but there was a time in my career that it was unaffordable, so I'm sensitive about being able to compile things with SharpDevelop, or Express edition if at all possible.

improvedk commented 11 years ago

I see your point, but then again I think the development audience for a project like this is very limited - and anyone daring to chip in will probably have not only a developer edition available, but also the internals books etc. Worst case, those few tests would be failing. But as you say - once the MDFs are prebuilt and included, this'll be a moot point :)