search

improvedk / OrcaMDF

A C# parser for MDF files. Allows you to read tables, metadata and indexes from MDF files without it being attached to a running SQL Server instance.
http://improve.dk/archive/2011/05/03/introducing-orcamdf.aspx
GNU General Public License v3.0
181 stars 74 forks source link

Would you accept a patch that caused OrcaMDF dependencies to be handled by nuget? #7

Closed zippy1981 closed 11 years ago

improvedk commented 11 years ago

Actually I'd prefer to just remove the only third party dependency there is - the AlphaVSS one. It's only used in the Adhoc project, which is just a test project that probably shouldn't even be part of the main repo itself. My goal is to not depend on any third party libraries itself, just to keep friction down and reduce any trust issues that might arise in case anyone is using the project on production databases. If you want to handle the dependency - feel free to remove any AlphaVSS dependencies from the codebase and the AlphaVSS dll's themselves. Then there should be no need for Nuget :)

zippy1981 commented 11 years ago

There are two references, nunit and the AlphaVSS. I think nunit makes sense to have a nuget reference.As far as the adhoc test program, if that's just an example, why not move it to a folder called contrib, include the test.mdf, and then people will treat it as an extra, not officiall supported thing?

improvedk commented 11 years ago

Gotcha - nunit is definitely valid for including through Nuget - I'd definitely accept a patch for that. As for Adhoc, I think I'd rather just remove it completely from the codebase. As is it's just been used for me to run some Adhoc queries through OrcaMDF, but really, it shouldn't be in the library. If people (like me) want to run it adhoc, they can just add a simple command like app themselves and reference the library, though outside of the codebase. That'd get rid of a lot of unrelated code changes and at the same time get rid of the AlphaVSS reference.