search

improving-minnesota / react-redux-timesheet

The timesheet project for the react-redux workshop
https://react-redux-timesheet.netlify.com
29 stars 197 forks source link

style: run prettier on entire code base #13

Closed DSchau closed 6 years ago

DSchau commented 6 years ago

This PR--which does not necessarily need to be merged--runs prettier on the code base so we can unify code style.

This also fixes some issues where we were directly mutating state (i.e. this.state =) instead of this.setState() like here

DSchau commented 6 years ago

Deploy preview for react-redux-timesheet ready!

Built with commit 3892bcc2e26860b4d0e331fcfa6554fae75c4eab

https://deploy-preview-13--react-redux-timesheet.netlify.com

meyerds commented 6 years ago

Initial reaction: I'd want to increase the max line length prettier runs with. Seems like it's wrapping lines way earlier than it needs to.

DSchau commented 6 years ago

Yeah, I can bump it up to 100, I won't die on that hill. I do like using the defaults mostly--although I've already set single quote up, so it's not as if there's not a precedent for that already.

tmartensen commented 6 years ago

Too many semicolons in here. Otherwise, this LGTM. 😉