search

improving-minnesota / react-redux-timesheet

The timesheet project for the react-redux workshop
https://react-redux-timesheet.netlify.com
29 stars 197 forks source link

refactor: add as a monorepo structure (just start for now) #6

Closed DSchau closed 6 years ago

DSchau commented 6 years ago

Basically the approach here was just to check out lab-xx-*-start and then create a folder with the contents. Nice thing is this approach will work super well with CodeSandbox and I think it's easier to maintain. Also with yarn workspaces (already configured) if people are using yarn it's one command and the child packages will all just work 🎉

Thoughts @jeffsheets @tmartensen?

Note: this will also require tweaking the lab Markdown files with new instructions (i.e. cd lab01 && yarn instead of check out a branch).

DSchau commented 6 years ago

Deploy preview for react-redux-timesheet ready!

Built with commit 914c332f2aa1c44d253a02fb13bb1f8b474cf6e4

https://deploy-preview-6--react-redux-timesheet.netlify.com

tmartensen commented 6 years ago

This will greatly help making changes to the projects, as now you don't have to push a change all the way up through every branch if you make a change in an "earlier" branch.

tmartensen commented 6 years ago

Lab 3: Either add the import './App.css'; to the file or add it to the instructions. Lab 4: Images at the end of lab 4 are broken.