imputnet / cobalt

save what you love
https://cobalt.tools
GNU Affero General Public License v3.0
13.97k stars 1.1k forks source link

Safari macOS : Popup is blurred on non HiDPI Screen #363

Open Write opened 6 months ago

Write commented 6 months ago

bug description

Any .popup windows appear blurred on Safari, caused by transform: translate(-50%,-50%); in .popup.visible css declaration. This does not happen on firefox

reproduction steps steps to reproduce the behavior:

  1. click on any links at the bottom that popup a windows
  2. text is blurred

screenshots

With transform: translate(-50%,-50%); :

Screenshot du 2024-02-19 à 11 12 05

With transform: translate(-50%,-50%); in .popup.visible and transform: translate(-50%,-48%)scale(.95); in .popup unticked in dev tools :

Screenshot du 2024-02-19 à 11 15 03

It still show as slightly blurred though.

On Firefox (same platform), the result is prefect :

Screenshot du 2024-02-19 à 11 16 16

platform

Note : This issue seems to only affect external-no HiDPI screen on macOS. While Firefox handles it fine. I directly checked cobalt on my MBP Native screen and it renders sharply. Not sure if there's a workaround.

wukko commented 4 months ago

does this happen only when switching windows between HiDPI screen and laptop screen?

Write commented 4 months ago

does this happen only when switching windows between HiDPI screen and laptop screen?

I never switch between the two because my mbp is always in clamshell mode. So assume all my screen are not in HiDPI mode and there's no switch.

So no, it happens all the time on non-HiDPI screen with Safari. On Firefox, like said before, works fine.

Anyway that's such a small issue… Not sure it's worth the time debugging it.

I'm still kinda surprised I couldn't find a css rule that make its render sharply on Safari, I haven't dug in too much though.

wukko commented 4 months ago

does it still happen? i tuned css a bit in the last month

Not sure it's worth the time debugging it

frontend will be (eventually) rewritten in svelte, so yeah, not really

Write commented 4 months ago

does it still happen? i tuned css a bit in the last month

Not sure it's worth the time debugging it

frontend will be (eventually) rewritten in svelte, so yeah, not really

Oh yeah, popup only, everything else is crystal clear. I have watchtower so I'm using the latest build

Screenshot du 2024-04-09 à 08 06 07

Rest of the UI crystal clear 👍 Screenshot du 2024-04-09 à 08 07 00

frontend will be (eventually) rewritten in svelte, so yeah, not really

Well feel free to close the issue, honestly.

wukko commented 4 months ago

feel free to close the issue

i'll keep it around just in case the issue sticks