imputnet / cobalt

save what you love
https://cobalt.tools
GNU Affero General Public License v3.0
13.93k stars 1.09k forks source link

Add audio metadata to "best" format #395

Open MarkimusZer0 opened 5 months ago

MarkimusZer0 commented 5 months ago

bug description I believe it's a bug, but downloading files (at least from YouTube) with the audio format set to best will cause them to come out without metadata

reproduction steps steps to reproduce the behavior:

  1. Have audio format set to best
  2. Download any video as an audio
  3. See error

videos

https://github.com/wukko/cobalt/assets/73902340/c6452348-cf58-484b-b9c3-3279bb2a392c

https://github.com/wukko/cobalt/assets/73902340/36f85822-f38a-40f0-ab7f-71d4152da07f

platform

additional context add any other context about the problem here.

wukko commented 5 months ago

this is expected behaviour because file is not modified by the processing server in any way. but i will convert this into a feature request :D