Refactoring the project name to chromo

impy-project / chromo

Hadronic Interaction Model interface in PYthon

Other

30 stars 7 forks source link

Refactoring the project name to chromo #116

Closed afedynitch closed 1 year ago

afedynitch commented 1 year ago

This PR changes everything from impy to chromo.

Additional minor changes:

The 19.x versions of DPMJET and PHOJET have been modified such that on chromo.debug_level = 0 they only print the badge and stay silent otherwise. For the old DPMJET and PHOJET versions such a change is not easily possible since all write statements are unprotected and print directly to an output unit. Sending output into the void is tmk impossible without significant workarounds.

HDembinski commented 1 year ago

@afedynitch Thanks for this, that was tedious job, I imagine.

I approved the change, but the folder f2py copy was committed by accident, I presume, and can be removed?

afedynitch commented 1 year ago

I approved the change, but the folder f2py copy was committed by accident, I presume, and can be removed?

Yes, totally. I removed it. Will merge after the tests pass. Hope it is ok if this one goes before the other PRs since it's kind of intrusive..?

HDembinski commented 1 year ago

Hope it is ok if this one goes before the other PRs since it's kind of intrusive..?

It is not an ideal moment, we could have planned it a bit better, but we have to make the change eventually, so I think you should go ahead. The other PRs can be updated accordingly.

afedynitch commented 1 year ago

It is not an ideal moment,

Agree but to get the package on pypi and the wheels working, we need to do this change as soon as possible.

HDembinski commented 1 year ago

Agree but to get the package on pypi and the wheels working, we need to do this change as soon as possible.

Agreed. I think we should keep the zero in front of the version number a while longer, to indicate that the API is not yet stable, but I also would like to have chromo binary wheels on pypi as soon as possible.