Closed HDembinski closed 1 year ago
So, I found the issues with PHOJET and likely with DPMJET decays, and the mystery difference between 19.1 and 19.3. I actually cleaned up these subroutines in 19.3, not perfectly, but there is some improvement :)
I need to backport 19.3 to 19.1 because no Omega- is definitely a bug.
@HDembinski Sorry, I hijacked your PR to make substantial fixed to the decays in all of the PHOJET/DPMJET models. I identified the issues and fixed them directly in the fortran codes and also in chromo. I can't request a review from you, but nonetheless I think you can do a review or comment if you wish.
I also changed the base of the PR to be the branch we're preparing for release.
This PR fixes the issues with DPMJET and PHOJET models, which didn't follow the decay settings controlled by chromo, and adds a test which checks that all particles which we expect to occur in the final state actually occur for all models.
Two exceptions are built into the test:
The PR fixes the following problems to make the test pass:
chromo
. The minor version of both codes have been upped by one to reflect the minor change.This PR closes #156.