impy-project / chromo

Hadronic Interaction Model interface in PYthon
Other
31 stars 7 forks source link

Roadmap for version 1.0 #165

Closed HDembinski closed 1 year ago

HDembinski commented 1 year ago

Before we release a version 1.0, we need to fix/settle a couple of things that will be breaking changes for some users.

Ping @afedynitch @jncots

jncots commented 1 year ago

Ok. I will try to fix #100 for a start.

HDembinski commented 1 year ago

@jncots Thanks! It is technically easy, but it is a delicate change to the API. We should not just change the indices returned in the children and parent arrays in EventData, because that would silently break everyones code that is doing the subtraction of 1 manually at the moment. I do that in all my scripts, for example.

I propose the following.

This how one gracefully changes the API without too much pain for the users.

Since we do not have so many users yet, we could shorten this and just remove parents and children without deprecation. But it is important that code which uses the old accessors with the old indexing convention (parents, children) fails in obvious ways instead of doing something wrong without giving any errors.