Closed afedynitch closed 1 year ago
I think that:
Sibyll23dStarNoEnh
SIBYLL*
is an unfortunate naming choice for us. I agree with @jncots that CapWords style for the new classes is the way to be PEP8 compliant, see https://peps.python.org/pep-0008/#class-names
@HDembinski I fixed the issues that you pointed out.
Further, I updated Sibyll* to patch release 2 that came in today with a bugfix. After your comments are resolved, I would like to merge this with to_release branch instead of main to bundle the numerous open PRs.
I implemented the comments by @jncots.
Also, I fixed the cross section readout for nuclei. It was necessary to include more categories into CrossSectionData
to accommodate the special categories for nuclei, such as "production" and "quasielastic". I updated the tests to accomodate these changes. This will close #130 .
This PR combines multiple items (sorry for that). The main novelty is SIBYLL* as shown at ICRC by F. Riehn:
-cpp
flag in CMake, and a second time by Ninja itself that calls the preprocessor by default. Fixing this restores the quick build times on machines with many cores.Opinions desired on: