search

impy-project / chromo

Hadronic Interaction Model interface in PYthon
Other
30 stars 7 forks source link

Lower ecm_min for EPOS-LHC #204

Closed HDembinski closed 2 months ago

HDembinski commented 2 months ago

As user Ashley pointed out, EPOS-LHC accepts sqrt(s) values down to 6 GeV, while we impose the limit at 10 GeV. This patch lowers our threshold to 6 GeV. I tried lowering it more, but then you get error messages from EPOS-LHC.

HDembinski commented 2 months ago

This fails for an unrelated reason. In the latest versions of Numpy, VisibleDeprecationWarning was removed. We use this to warn about using deprecated API. Henry told me the proper warning to use is FutureWarning. I am going to replace the affected warnings to make the tests pass.

There is also DeprecationWarning but that is intended for other libraries that use chromo and not end-users. DeprecationWarning is suppressed unless triggered in the main program (context __main__), so it might not show up. FutureWarning is always shown. https://docs.python.org/3/library/warnings.html

jncots commented 2 months ago

@HDembinski, VisibleDeprecationWarning has been moved to numpy.exceptions.VisibleDeprecationWarning. This is how I tried to fix it in https://github.com/impy-project/chromo/pull/203. But your solution relies on core Python, so as I understand, is more general.

Anyway, it is the least of problems introduced by numpy 2.0. Some problems would probably require f2py people again, because Epos LHC doesn't build for Windows.

HDembinski commented 2 months ago

Ok, can then still merge this even if the tests fail, since we know they fail for other reasons?

HDembinski commented 2 months ago

For now, we need to restrict the numpy version as a workaround for this problem. I am currently testing a change to setup.cfg to that effect. Please do not merge yet.

HDembinski commented 2 months ago

It is already set for UrQMD, no?

jncots commented 2 months ago

You are right, _ecm_min is set for UrQMD. I confused it with some other model.