Closed curtcorum closed 1 year ago
Describe the bug GRE Walkthrough notebook seems to have multiple bugs, with v1.4.0 at least
To Reproduce gre_walkthrough.ipynb on colab
Expected behavior Halts on:
from pypulseq.make_trap_pulse import make_trapezoid
when above fixed halts next on:
rf, gz, gzr = make_sinc_pulse(flip_angle=alpha * math.pi / 180, duration=4e-3, slice_thickness=slice_thickness, apodization=0.5, time_bw_product=4, system=sys)
did not go farther...
Screenshots
Desktop (please complete the following information): gre_walkthrough.ipynb on colab
pypulseq
Additional context Have not tried locally, some other examples seem to run ok on colab.
Thanks for catching this. It looks like this example is based on PyPulseq 1.3.0. If you have a working version, feel free to submit a PR. Otherwise, I can have a crack at it when I have the time.
Solved in #121.
Describe the bug GRE Walkthrough notebook seems to have multiple bugs, with v1.4.0 at least
To Reproduce gre_walkthrough.ipynb on colab
Expected behavior Halts on:
from pypulseq.make_trap_pulse import make_trapezoid
when above fixed halts next on:
rf, gz, gzr = make_sinc_pulse(flip_angle=alpha * math.pi / 180, duration=4e-3, slice_thickness=slice_thickness, apodization=0.5, time_bw_product=4, system=sys)
did not go farther...
Screenshots
Desktop (please complete the following information): gre_walkthrough.ipynb on colab
pypulseq
version: 1.4.0Additional context Have not tried locally, some other examples seem to run ok on colab.