Closed FrankZijlstra closed 6 months ago
Thanks for the PR!
I'm in favour of option 1 because of the disadvantage with option 2 you mentioned. It seems like coming across an error about multiple gradients and then manually adding gradients is safer than passing multiple gradients and spending time debugging because the output looks different.
I reverted the second commit so at least the basic fix can be pushed!
I feel like there is no disagreement on the basic fix, so merging.
As title. There are two options here:
Personally I'm in favour of option 2, because it seems like pretty natural behaviour, and it can come up in some instances: e.g. specifying a slab-selection refocusing gradient along with a phase-encoding gradient in 3D imaging. An argument against this behaviour is that it hides something the user should ideally be aware of, and you may end up with weird gradient shapes if the timing of gradients is not aligned.