imr-framework / pypulseq

Pulseq in Python
https://pypulseq.readthedocs.io
GNU Affero General Public License v3.0
115 stars 62 forks source link

Wrong time unit in function documentation #63

Closed mavel101 closed 2 years ago

mavel101 commented 2 years ago

The time unit in the description of more or less all event block objects (such as pulses, gradients,...) is wrong. The time unit in PyPulseq is seconds [s] instead of milliseconds [ms] as stated in the descriptions. This might be confusing especially for new users.

sravan953 commented 2 years ago

Thanks @mavel101 ! Will fix.

sravan953 commented 2 years ago

Hi @mavel101 ! Commit https://github.com/imr-framework/pypulseq/commit/cc4aa8d4a50b2a17d4e375306d5d322e70ceac75 should fix this, thanks for bring this up!