imr-framework / pypulseq

Pulseq in Python
https://pypulseq.readthedocs.io
GNU Affero General Public License v3.0
115 stars 62 forks source link

Function to appends the md5_hash signature to the .seq file to make it compatible with pulseq Version 1.4 #64

Closed Nikbert closed 2 years ago

Nikbert commented 2 years ago

Is your feature request related to a problem? Please describe. Pulseq Version 1.4 requires a md5_hash signature at the end of the .seq file

Describe the solution you'd like A function that appends the signature to make the .seq file compatible with Pulseq V1.4. Calling the function "add_signature.add_md5_sig(file_name)" after the "seq.write()" function will append the required signature.

Describe alternatives you've considered An alternative would be to include the function in the seq.write function. This would be the preferred solution in the future.

There is a pull request for the described add_signature.py function

sravan953 commented 2 years ago

Hello @Nikbert ! Thanks for opening this issue + the PR! I am already working on this and hope to push out PyPulseq 1.4.0 soon! Stay tuned! :)

sravan953 commented 2 years ago

Hi @Nikbert , thanks for being patient! Commit https://github.com/imr-framework/pypulseq/commit/f36f91a7dd7ff7c0b37ce0f559312c918f63afe4 adds this functionality. Take a look - https://github.com/imr-framework/pypulseq/blob/f36f91a7dd7ff7c0b37ce0f559312c918f63afe4/pypulseq/Sequence/write_seq.py#L245