search

imrahil / OctoPrint-NavbarTemp

Plugin for OctoPrint - displays temperatures on navbar
GNU Affero General Public License v3.0
44 stars 50 forks source link

[Feature] Added possibility to configure displaynames of temperatures #34

Open koelle25 opened 6 years ago

koelle25 commented 6 years ago

Hi @imrahil,

as the OctoPrint webinterface layout doesn't offer a lot of width I have added options to the settings so that one can configure which name should be displayed beneath the temperatures - so that it can be shorter if one wants (e.g. when using this plugin in conjunction with DisplayLayerProgress.

Here is a screenshot for an example (my personal configuration): 2018-05-14 19_29_42-anet a8 octoprint

I think this is a cool addition and would love if you accept my PR.

Regards, Kevin

Cosik commented 4 years ago

@koelle25 are you still want to add this features? If yes please resolve merge conflits and then we could make a review.

spacecabbie commented 3 years ago

this is indeed a nice addition @koelle25 if you are to busy mind if i pick it up and fix ?

koelle25 commented 3 years ago

@spacecabbie For sure you can! I hadn't had the chance and passion to look into all those conflicts which came up with time (this PR is now almost 2 years old). I guess I'll have to add you to my fork as a collaborator, is that right?

spacecabbie commented 3 years ago

@spacecabbie For sure you can! I hadn't had the chance and passion to look into all those conflicts which came up with time (this PR is now almost 2 years old). I guess I'll have to add you to my fork as a collaborator, is that right?

Yes if you want to keep credit for the change. I can just copy it as a new commit but that it would show up under my name.