search

imrahil / OctoPrint-NavbarTemp

Plugin for OctoPrint - displays temperatures on navbar
GNU Affero General Public License v3.0
44 stars 50 forks source link

plugin stopped working after 0.11 update #44

Closed sigurg closed 5 years ago

sigurg commented 5 years ago

I just updated NavbarTemp to version 0.11 and it seems this release is broken with my octoprint install.

Log shows the following error while loading:

2018-10-16 17:12:27,324 - octoprint.server.views - ERROR - Error while retrieving template data for plugin navbartemp, ignoring it Traceback (most recent call last): File "/venv/local/lib/python2.7/site-packages/OctoPrint-1.3.9-py2.7.egg/octoprint/server/views.py", line 635, in fetch_template_data configs = implementation.get_template_configs() File "/venv/local/lib/python2.7/site-packages/octoprint_navbartemp/init.py", line 82, in get_template_configs if self.sbc.is_supported: AttributeError: 'NoneType' object has no attribute 'is_supported'

Octoprint version is 1.3.9 on Debian (testing, x86_64).

Cosik commented 5 years ago

@sigurg what is your hardware platform? Do you use armbian monitor? How do you read temperature manually from command line?

sigurg commented 5 years ago

Hardware is standard PC (core i7), thus I have no armbian monitor or anything. I'm only interested in printer bed/nozzle temp, which used to work thus far... (in theory you could read temps from /sys/class/thermal/ or lm-sensors, but that's not really useful, imho)

Cosik commented 5 years ago

Ok I will check it asap. Please expect message with test request.

imrahil commented 5 years ago

@cosik I think that changes for armbian platforms broke something for Windows and/or Linux...

Cosik commented 5 years ago

@sigurg please uninstall plugin and check it from this source https://github.com/Cosik/OctoPrint-NavbarTemp/archive/bug-fix/normal-pc-support.zip And then please comment results here: https://github.com/imrahil/OctoPrint-NavbarTemp/pull/45

Turtletrumpet commented 5 years ago

Hello,

I had the same problem after update to 0.11 like sigburg(Debian 8(32bit) on PC). I installed manual via https://github.com/Cosik/OctoPrint-NavbarTemp/archive/bug-fix/normal-pc-support.zip and all is fine!! Thanks for your work!

Cosik commented 5 years ago

@Turtletrumpet thanks for testing. @imrahil what now? we should make new release? Or how we should provide bug-fixes?

imrahil commented 5 years ago

From now all new installations will be using fixed code. For people who upgraded to 0.11 reinstallation should help.

Next release should contain better fix for non-arm platforms.

sigurg commented 5 years ago

Sorry for the delay, my machine was printing so I could not test your fix earlier. I just re-installed the plugin and can confirm your fix is working on my system. Thank you for the quick fix!

Cosik commented 5 years ago

ok, so we could close it.