search

imrahil / OctoPrint-PrintHistory

Plugin for OctoPrint - saves filename, print time and filament usage for each print
GNU Affero General Public License v3.0
64 stars 64 forks source link

Fix parsing error of Cura parameters for >= 3.1 #74

Closed lumbric closed 5 years ago

lumbric commented 6 years ago

Fixes a MissingSectionHeaderError for GCODE files generated with Cura version 3.1 or higher.

Cura added a second entry to the JSON here: https://github.com/Ultimaker/Cura/commit/64ecb114b86f663ea096054e108db43b1867bfd6

truglodite commented 6 years ago

I am having this exact issue with this plugin. Has your patch worked well so far? Btw, cheers for working to fix this abandoned project. I think many folks depend on it and your work is truly appreciated.

lumbric commented 6 years ago

Yes, I've tested it and we using the patched version. But Cura seems to change the header from time to time, so there will be no guarantee for future Cura versions...

droscy commented 5 years ago

I've tested the patch with Cura 3.5.1 and it worked correctly. Many thanks.

alexisju commented 5 years ago

Why the patch is not merged and the plugin updated ? Does we need to make a fork to keep the plugin working?

lumbric commented 5 years ago

Hm the last commit was 2 years ago. @imrahil do you still maintain this plugin? Do you want to hand over maintainership?

imrahil commented 5 years ago

Merged. @lumbric yes, help is always welcomed.