search

imrahul361 / Competitive-Programming-Libraries

Creating a C++ Library for easily accessible different functions/Algorithms that are used in Competitive programming.
3 stars 6 forks source link

KMP Algorithm added #25

Closed codewdhruv closed 3 years ago

codewdhruv commented 3 years ago

fixed #1

imrahul361 commented 3 years ago

Single File with implementation and Comment how the function and each loops are working Review properly. @dhrubajyoti89 Don't add Read.md

codewdhruv commented 3 years ago

@imrahul361 do i need to add the main implementation as well?

imrahul361 commented 3 years ago

You are not commenting properly on the working. Go and Learn about this Algorithm before make new PR on it. @dhrubajyoti89 Rejecting your PR

codewdhruv commented 3 years ago

i have explained the working in the readme but you didnt accept it what comments do you expect from me in this simple two function implementation? @imrahul361

imrahul361 commented 3 years ago

it's for the use of Beginner. The thing is that it might be easy for you but that might be difficult for someone. I am creating this repo for beginner in Competitive Programming. @dhrubajyoti89