Closed Itsmeeeet closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
soen-390-team05-w23-front-end | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 18, 2023 5:18pm |
Added Delete Confirmation box :
And also fixed the scrollbar of JobPosting page
Here are my comments regarding the conflicts:
In regards to the JobList page, the CSS change was made to prevent the footer from always being visible at the bottom of the browser window. I think it would be better to have the footer at the very bottom of the page.
Here's what I mean. The first gif demonstrates your changes made.
See how the footer is always visible in the browser window? The following gif demonstrates my CSS changes.
To make my trick work, I had to include the Navbar and the Footer inside the component JobList.jsx
. The conflict is due to the following image
I added a new div that takes care of the page height, and the navbar at the very top. I also created a new CSS file for the LoginFooter loginfooter.module.css
and for this page JobList.module.css
which are currently being used in dev_new
. Thus, the class names were modified to retrieve the name from the module file.
To solve this conflict, you can either do the following:
App.jsx
, which were removed to make my trick work.I hope this was helpful. Let me know if you have more questions 🙂
Accept your changes as the navbar and footer was added to the jobList page in App.js in PR #222
Job Posting and Job Postings Summary