imran1289-ah / ConnectIn

SOEN 390 team 05 winter 2023
https://connectin.vercel.app/signin
2 stars 6 forks source link

Updated CSS and Responsiveness - Job Posting and Job Postings Summary #192

Closed Itsmeeeet closed 1 year ago

Itsmeeeet commented 1 year ago

Job Posting and Job Postings Summary

  1. Job Posting page

Screenshot 2023-04-14 at 9 53 20 PM

Screenshot 2023-04-14 at 9 52 51 PM

Screenshot 2023-04-14 at 9 52 36 PM

Screenshot 2023-04-14 at 9 49 28 PM

  1. Job Posting Summary Page

Screenshot 2023-04-14 at 9 55 14 PM

Screenshot 2023-04-14 at 9 54 52 PM

Screenshot 2023-04-14 at 9 54 34 PM

Screenshot 2023-04-14 at 9 53 40 PM

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
soen-390-team05-w23-front-end ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2023 5:18pm
Itsmeeeet commented 1 year ago

Added Delete Confirmation box :

Screenshot 2023-04-17 at 3 45 44 PM Screenshot 2023-04-17 at 3 45 55 PM Screenshot 2023-04-17 at 3 46 06 PM

And also fixed the scrollbar of JobPosting page

Aboudik1452 commented 1 year ago

Here are my comments regarding the conflicts:

In regards to the JobList page, the CSS change was made to prevent the footer from always being visible at the bottom of the browser window. I think it would be better to have the footer at the very bottom of the page.

Here's what I mean. The first gif demonstrates your changes made. firefox_MUQrsyuYdA

See how the footer is always visible in the browser window? The following gif demonstrates my CSS changes.

brave_IhBupcNNCN

To make my trick work, I had to include the Navbar and the Footer inside the component JobList.jsx. The conflict is due to the following image image

I added a new div that takes care of the page height, and the navbar at the very top. I also created a new CSS file for the LoginFooter loginfooter.module.css and for this page JobList.module.css which are currently being used in dev_new. Thus, the class names were modified to retrieve the name from the module file.

To solve this conflict, you can either do the following:

I hope this was helpful. Let me know if you have more questions 🙂

imran1289-ah commented 1 year ago

Accept your changes as the navbar and footer was added to the jobList page in App.js in PR #222