Closed imranhossainemi closed 1 year ago
Hi @imranhossainemi , @ikoote1 and @Santosh-Konappanavar ,
While you made a great effort in this project, I can't go ahead and review your code.
development
branch merging into the main
branch. This was communicated to you in this article: https://github.com/microverseinc/curriculum-transversal-skills/blob/main/code-review/articles/code_review_flow_group_projects.md .Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me @NahnahAJ in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.
Project Update
1.Team member # 1 - Imran Hossain
2. Team member # 2 Santosh Konappanavar
Create MusicAlbum class in a separate .rb file.
Create a Genre class with an association to the Item class (in a separate .rb file).
All MusicAlbum class properties visible in the diagram should be defined and set up in the constructor method.
All Genre class properties visible in the diagram should be defined and set up in the constructor method.
Implement methods:
add_item method in the Genre class
should take an instance of the Item class as an input
should add the input item to the collection of items
should add self as a property of the item object (by using the correct setter from the item object)
can_be_archived?() in the MusicAlbum class
should override the method from the parent class
should return true if the parent's method returns true AND if on_spotify equals true
otherwise, it should return false
Add unit tests for all implemented methods.
The following options should be available:
All data should be preserved by saving collections in .json files.
Create a schema.sql file with tables that will be analogical to the structure of the classes that you created: music_albums table (add all properties and associations from the parent Item class as table columns) genres table
3. Team Member # 3 Ikoote Rasuli
Implement methods:
The following options should be available: