Open imranhossainemi opened 1 year ago
Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!
Hi @Team 💯
Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation but you are almost there!
Example:
For the group task
Create a new Issue for each task and assign all the member teams for this task. And so on, for each task in the requirement. Same with the task for team members #1, #2 and #3
Check the comments under the review.
You can use as many of my suggestions as you want. If there is anything you would like to skip - feel free to do that. However, I strongly recommend you to take them into account as they can make your code better._
You can also consider:
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Great work on making the changes requested by a previous reviewer 👏 You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi @imranhossainemi, @Santosh-Konappanavar & @ikoote1 🙋♀️
Great work implementing the suggested changes 💪 Your project is COMPLETE! 🚀 Congratulations!
There are some excellent points that you have made perfectly. Keep up the great work! 👏
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
N/A
Cheers and Happy coding!👏👨💻💻
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Project link : https://github.com/imranhossainemi/catalog_of_my_things/projects/1
In this group project , we are three people. Whom divide the work in this list: