imranhsayed / frontity-contact-form-7

🔥 Contact Form 7 extension for Frontity theme.
66 stars 12 forks source link

Deprecated property: 'process' #16

Open DarkChris86 opened 4 years ago

DarkChris86 commented 4 years ago

Hey @imranhsayed!

I got the following message in frontity app: image

Bests, Chris

luisherranz commented 4 years ago

Hey @DarkChris86, thanks for the PRs 🙂

If you look at the docs, the signature of the functions also changed. Now they receive objects, like this:

const processor = {
  test: ({ node }) => { /* ... */ },
  processor: ({ node }) => { /* ... */ },
};

The change is backward compatible but we will deprecate the old API at some point. Would you mind adding that change to your PRs? Thanks!!

DarkChris86 commented 4 years ago

Hey @luisherranz .

Yes, I'm going to modify them like this! Thank you for friendly note! ; )

luisherranz commented 4 years ago

Thanks to you @DarkChris86! 😄

DarkChris86 commented 4 years ago

It's done. Could you check them ( @luisherranz )?

Thanks, Chris

imranhsayed commented 4 years ago

@DarkChris86 Approved and merged the PR.

DarkChris86 commented 4 years ago

@imranhsayed When it will be available via npm update? https://www.npmjs.com/package/frontity-contact-form-7

Thanks, Chris

luisherranz commented 4 years ago

Thanks @DarkChris86! 🙌 🙂 (and @imranhsayed)

davidrhoderick commented 4 years ago

I'm still getting this error on the latest version installed by NPM (0.1.4), plus the form isn't showing up on a page that renders the code to a page via a custom field using <Html2react />. Anything I can do to fix the error and will it fix the contact form?

EDIT: The form works, I just needed to use a WYSIWYG field instead of a text area as provided by ACF Pro.

luisherranz commented 4 years ago

@imranhsayed can you please release a new version in npm?

davidrhoderick commented 4 years ago

@imranhsayed any update on releasing a new version in npm? The contact form isn't even showing up on my site now.

It's funny, on my laptop, I don't get this error, so it might be related to the version of npm being used. I'll look into this a bit more...

imranhsayed commented 4 years ago

Released the new version on npm

davidrhoderick commented 4 years ago

Thanks @imranhsayed the latest version doesn't have this bug but I have found a new error with the latest version I will create another issue about.