search

imsky / PocketEuler

:heavy_plus_sign: Offline version of Project Euler.
116 stars 11 forks source link

Fix Unicode bullet and nbsp in list entry prefix #38

Closed jayvdb closed 8 years ago

jayvdb commented 8 years ago

The unicode bullet (•) and nbsp were being used as bullets, however they are not recognised by Markdown syntax.

jayvdb commented 8 years ago

Fixes #37

jayvdb commented 8 years ago

On this and #40 , I have used a leading space before bullets. I found lots of cases with and without this. I dont mind which is used; I am happy to update the patches to have no leading spaces if you prefer.

imsky commented 8 years ago

:+1:

jayvdb commented 8 years ago

Before merging this, I will test how the lint tools act if the leading space is removed, and report back.

imsky commented 8 years ago

sounds good

imsky commented 8 years ago

@jayvdb ready to merge?

jayvdb commented 8 years ago

No. I've got a revised version which uses 4 space indent, and other improvements after working with the author of remark to remove a few of its bugs. Will review and push it up now.

jayvdb commented 8 years ago

(still rechecking rendering & linting, considering https://github.com/wooorm/remark/issues/196 we may have some problems with some math)

jayvdb commented 8 years ago

Looks good. The only render problem I can see is https://github.com/imsky/PocketEuler#problem-438 , but that is slightly improved by this PR, and will be fixed in the next PR.

I havent checked for any new lint errors, but I did check for some obvious problems (like the underscores in Problem 43 causing new lint errors - none).

imsky commented 8 years ago

:shipit:

jayvdb commented 8 years ago

I've done some minor tidying, especially fixing the list-item-spacing lint errors. Will skip through it one more time then merge in ~ an hour.