imsky / holder

:city_sunrise: Client-side image placeholders.
http://holderjs.com
MIT License
5.84k stars 592 forks source link

RTL support #176

Open redayoub opened 8 years ago

redayoub commented 8 years ago

Hi,

Does Holder.js support RTL text? If not, is there any way to that?

Thanks.

imsky commented 8 years ago

that should be straightforward to implement. could you provide an example, and how you'd want it to display? i'm not an expert on RTL rendering so i'd like to ensure it works with real-world use cases first.

redayoub commented 8 years ago

I'm using it with arabic text, so for exemple the text : "الدار البيضاء" is displayed like that "البيضاء الدار " inside a holder image. In css we can do that by setting text direction to rtl.

imsky commented 8 years ago

ok i'll add that as a test, thanks

redayoub commented 8 years ago

Thanks

redayoub commented 8 years ago

How can I add this manually please ?

imsky commented 8 years ago

i'm not sure if it can be done manually. the only thing i can think of is reversing the string before passing is to Holder

PerseusTheGreat commented 7 years ago

The below link introduces you, useful references to rendering RTL text in SVG. W3C - SVG Text direction Good luck.

imsky commented 7 years ago

thanks @PerseusTheGreat