search

imsky / holder

:city_sunrise: Client-side image placeholders.
http://holderjs.com
MIT License
5.84k stars 592 forks source link

noBackgroundSize not working #183

Closed ivancuric closed 8 years ago

ivancuric commented 8 years ago

Still outputs the background size property.

the JS:

Holder.run({
  noBackgroundSize: true
});

The CSS:

.hero {
  background-image: url(?holder.js/1920x400?theme=sky&text=%20);
}

The output:

<div class="hero holderjs" data-background-src="holder.js/1920x400?theme=sky&amp;text=%20" data-holder-rendered="true" style="background-image: url(...); background-size: 1920px 400px;">
imsky commented 8 years ago

I don't see this happening: https://jsfiddle.net/h3asubr3/

The only thing I can think of is Holder.run running before your second call. If there's a live URL where this can be reproduced with the current build, let me know.

ivancuric commented 8 years ago

I did an npm update, but the package wasn't updated on NPM. Works now.

imsky commented 8 years ago

great, thanks for checking