search

imsky / holder

:city_sunrise: Client-side image placeholders.
http://holderjs.com
MIT License
5.84k stars 592 forks source link

[Enhancement] Diagonal lines/border? #213

Closed Quix0r closed 6 years ago

Quix0r commented 6 years ago

Is it possible to render diagonal lines and a border? I mean something like this:

http://dhiglobal.com/wp-content/uploads/2016/07/placeholder.jpg

Here, the border is missing, maybe a new config border = true/false (default: false) and diagonals = true/false (default: false)?

imsky commented 6 years ago

this already exists, use outline=1, e.g. <img data-src="holder.js/300x200?outline=1">

example: https://jsfiddle.net/m28ntzou/

screen shot 2017-10-23 at 11 09 42 am

Quix0r commented 6 years ago

Thank you. Maybe I oversaw that option. And it works here.

imsky commented 6 years ago

sure thing @Quix0r, glad it worked out

Quix0r commented 6 years ago

Hmm, if I use border-size: xFOO like 5px, the border is not rendered on the rounded border corners. Maybe a general issue with CSS?

imsky commented 6 years ago

@Quix0r i'm not 100% sure what you mean. can you post a jsfiddle with the issue?

Quix0r commented 6 years ago

Again signing up somewhere ... :-/ I have uploaded a screenshot to my nextcloud instance: https://cloud.mxchange.org/index.php/s/149vSQYmDeENiuY?path=%2Fholderjs#/holderjs/20171102%20-%20Rounded%20Corner%20-%20001.png

imsky commented 6 years ago

you can use jsfiddle without signing up @Quix0r

good point about the rounded corners - that wasn't factored into the "outline" feature. i'll file an issue to support this.

Quix0r commented 6 years ago

Maybe I looked too fast. Anyway. Thank you for supporting this.