imsky / holder

:city_sunrise: Client-side image placeholders.
http://holderjs.com
MIT License
5.84k stars 592 forks source link

100% x 100% giving <svg> error in Chrome Canary Version 69.0.3494.0 (Official Build) canary (64-bit) #220

Closed etetlow closed 6 years ago

etetlow commented 6 years ago

Wanted a 500 x 500 fully responsive image so wrapped image in a div with class promo-image and...

.promo-image { position: relative; display: block; width: 100%; padding-top: 100%; } .promo-image img { position: absolute; top: 0; left: 0; right: 0; bottom: 0; width: 100%; height: 100%; }

and made img data-src holder.js/100px100p

Gives error:

Error: attribute viewbox: Expected number, "0 0 100% 100%".

When I url-decoded the src in developer tools that's exactly what it says in the svg. Don't know where we go from here, but thought you might want to know.

etetlow commented 6 years ago

Forget about this one, updated Canary to 70, took off the textmode and all is good.