search

imsky / holder

:city_sunrise: Client-side image placeholders.
http://holderjs.com
MIT License
5.84k stars 593 forks source link

Upgrade shaven dependency #233

Closed vbjay closed 3 years ago

vbjay commented 3 years ago

Closes #232 Related

209

ad-si/shaven#44

vbjay commented 3 years ago

image

Your builds are still failing 2 years and counting.

https://travis-ci.org/github/imsky/holder/pull_requests

imsky commented 3 years ago

thanks @vbjay

i'm reworking the builds sometime soon - likely migrating off of travis

ryanrapini commented 3 years ago

I'm still getting this error, am I missing something? I think you have to publish to npm for this update to go in.

vbjay commented 3 years ago

Correct. Npm hasn't been updated.

On Fri, Jan 1, 2021, 4:14 PM Ryan Rapini notifications@github.com wrote:

I'm still getting this error, am I missing something? I think you have to publish to npm for this update to go in.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/imsky/holder/pull/233#issuecomment-753383151, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3WDMI7HSV5INQDQ7WARCLSXY3MZANCNFSM4UPVU2CQ .

imsky commented 3 years ago

@vbjay @ryanrapini 2.9.9 - just released - should fix the issue

ryanrapini commented 3 years ago

Thanks, fixed the issue for me.