search

imsnif / monocle

A Zellij plugin to fuzzy find file names and contents in style 🧐
MIT License
135 stars 9 forks source link

[fix]: migration to zellij 0.38 (https://github.com/imsnif/monocle/issues/5) #7

Closed karimould closed 1 year ago

karimould commented 1 year ago

Fix for https://github.com/imsnif/monocle/issues/5

This should make the plugin work in zellij 0.38 again :-)

Since I have only been using zellij since version 0.38, I don't know what the default behavior was :-)

If anything else needs to be done, feel free to guide me in the right direction or take over yourself.

Enjoy your remaining holidays and thank you very much for the work on zellij.

Jengamon commented 1 year ago

I have an MR for this already (#6), but I would future-proof this by using the constructors new_to_plugin and new_to_worker for PluginMessages rather than constructing them directly

Also, a None for worker_name mostly likely means respond to the plugin, so the manually constructed are flipped (the constructors order of arguments match the old API, so that's another point in favor of using it).

karimould commented 1 year ago

Ah I didn't saw your PR sorry :-).

I'am still exploring Rust so thank you for the informations, you solutions makes much more sense :-).

I'll close the PR