imsory / gnome2-globalmenu

Automatically exported from code.google.com/p/gnome2-globalmenu
GNU General Public License v2.0
0 stars 0 forks source link

Propose as a Gnome Module #388

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
http://live.gnome.org/ReleasePlanning/ModuleProposing
This is our last chance to get included before 3.0. We have to win the
souls and hearts on the ML to get included in the panel applets.

Original issue reported on code.google.com by pierre.s...@gmail.com on 2 Apr 2009 at 1:44

GoogleCodeExporter commented 8 years ago
To be read on Gnome Shell compat:
http://smspillaz.wordpress.com/2009/04/02/compiz-09x-where-are-we-now-and-where-
to-from-here/

Original comment by pierre.s...@gmail.com on 2 Apr 2009 at 5:25

GoogleCodeExporter commented 8 years ago
http://blogs.gnome.org/aklapper/2009/04/02/gnome3schedule/

Original comment by pierre.s...@gmail.com on 2 Apr 2009 at 5:34

GoogleCodeExporter commented 8 years ago
@pierre,

Will you have time to make a draft? 

Original comment by rainwood...@gmail.com on 2 Apr 2009 at 7:17

GoogleCodeExporter commented 8 years ago
I'm on it in the wiki.

Original comment by pierre.s...@gmail.com on 3 Apr 2009 at 1:43

GoogleCodeExporter commented 8 years ago
Remove from the milestone.
@pierre, any good news on this?

Original comment by rainwood...@gmail.com on 27 Jun 2009 at 5:52

GoogleCodeExporter commented 8 years ago
Nope. The deadline was at the worst possible moment ever, and I couldn't finish 
the
application in reasonnable time.
We should finish though and submit it ASAP so as to permit to the idea to sink 
into
minds.

Original comment by pierre.s...@gmail.com on 27 Jun 2009 at 11:58

GoogleCodeExporter commented 8 years ago

Sorry, but when is the deadline again?

Original comment by rainwood...@gmail.com on 27 Jun 2009 at 12:14

GoogleCodeExporter commented 8 years ago
http://live.gnome.org/TwoPointTwentyseven
Nov 16 (we missed the deadline for this release)

Original comment by pierre.s...@gmail.com on 27 Jun 2009 at 3:42

GoogleCodeExporter commented 8 years ago
I am applying the gnome git repository, as the first step. we may apply for the
module later.

I can tolerant svn no more. Too messy to work on a different branch will fixing 
bugs
in the trunk on the same time with svn.

Original comment by rainwood...@gmail.com on 4 Jul 2009 at 5:09

GoogleCodeExporter commented 8 years ago
Issue 449 has been merged into this issue.

Original comment by rainwood...@gmail.com on 4 Jul 2009 at 5:10

GoogleCodeExporter commented 8 years ago
I have setup my git repo at 

github.com/fengy-research/globalmenu

the gnome git decision may arrive a couple of weeks later,
I'll try to push my changes to the googlecode site before we receive any 
feedback
from gnome.

Original comment by rainwood...@gmail.com on 6 Jul 2009 at 9:33

GoogleCodeExporter commented 8 years ago
Heja,

apart from what is already mentioned in
http://live.gnome.org/ReleasePlanning/ModuleProposing you should not depend on 
any
deprecated modules or functionality either for GNOME 3. It's not mentioned on 
that
wikipage currently, sorry. I should fix that. :-/

1) libgnome(ui): Currently you still use libgnome here:
./applet/applet.c:#include <libgnome/libgnome.h>
See http://live.gnome.org/LibgnomeMustDie
gnome_url_show() in that code definitely has to die.

2) libbonobo(ui) dependency is probably required currently, unfortunately.

3) libglade: Seems that you use libglade instead of Gtkbuilder as 
test-unload.glade
exists. See http://live.gnome.org/GnomeGoals/RemoveLibGladeUseGtkBuilder

4) Your code should not use any Glib/GTK signals that are deprecated. To check, 
use
make CFLAGS+="-DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED
-DGTK_DISABLE_DEPRECATED -DG_DISABLE_DEPRECATED"
See http://live.gnome.org/GnomeGoals/RemoveDeprecatedSymbols/GTK%2B and
http://live.gnome.org/GnomeGoals/RemoveDeprecatedSymbols/Glib

5. Your code should only use GTK/Glib single includes. This is currently not the
case. See http://live.gnome.org/GnomeGoals/CleanupGTKIncludes

Original comment by andre.kl...@gmail.com on 24 Jul 2009 at 8:45

GoogleCodeExporter commented 8 years ago
...ah, forgot: Your translations probably need a review too by the GNOME 
translation
teams. Just took a quick look at the German one and I'm not happy with the 
quality.

Original comment by andre.kl...@gmail.com on 24 Jul 2009 at 8:47

GoogleCodeExporter commented 8 years ago
Thanks for the report.

I will be able to carefully examine these problems soon. I have a feeling that 
some
of the issues will be tough.

1) is easy to fix
3) we don't use libglade. The glade file is converted to .ui anyways. I'll 
remove the
.glade file soon
4) I remember we are directly accessing some members because there are no 
accessor
functions yet(eg, accel_string in GtkAccelLabel). I can make sure all the 
fixable
ones are fixed.

5) I hope it is not a Vala problem. Could be be more specific about it?

Original comment by rainwood...@gmail.com on 30 Jul 2009 at 9:55

GoogleCodeExporter commented 8 years ago
4) For pending GTK+ sealings see 
http://bugzilla.gnome.org/show_bug.cgi?id=588339 .
That's not necessarily related though. Can you try compiling gnome2-globalmenu 
with
the flags I've mentioned? If it works you're on the safe side currently. :-)

5) What's unclear with the wikipage that I provided?

Original comment by andre.kl...@gmail.com on 30 Jul 2009 at 5:14

GoogleCodeExporter commented 8 years ago
1 and 3 are fixed.

For 4, I end up with an error with bonobo ui's header files:
/usr/include/libbonoboui-2.0/bonobo/bonobo-ui-toolbar-item.h:51: error: expected
declaration specifiers or ‘...’ before ‘GtkTooltips’
Do you have any ideas about it?

For 5, I can see the CCode is including pango headers or gdkx headers. 
Shouldn't I
use them?

Original comment by rainwood...@gmail.com on 31 Jul 2009 at 7:41

GoogleCodeExporter commented 8 years ago
4) See http://library.gnome.org/devel/gtk/stable/GtkTooltips.html :
"GtkTooltips has been deprecated in GTK+ 2.12, in favor of the new GtkTooltip 
API."

5) pango has nothing to do with gtk and glib. gdk/gdkx.h... no real idea.
Does it compile with the flags listed in
http://live.gnome.org/GnomeGoals/CleanupGTKIncludes ?

Original comment by andre.kl...@gmail.com on 31 Jul 2009 at 11:22

GoogleCodeExporter commented 8 years ago
(Note that module proposal period for GNOME 2.30 has been moved, see
http://live.gnome.org/TwoPointTwentyseven/ and the announcement at
http://mail.gnome.org/archives/devel-announce-list/2009-July/msg00007.html )

For #4 I checked out from svn and ran "egrep -n -R -f
/home/andre/gnome/greps/gtk-dep-symbols.list gnome-globalmenu" to find all
appearances of deprecated symbol use:

gnome-globalmenu/gtk-modules/macmenu/test-integration.c:93: 
gtk_widget_set_sensitive
(copy_item, !sensitive);
gnome-globalmenu/gtk-modules/macmenu/test-integration.c:216:
gtk_button_box_set_spacing (GTK_BUTTON_BOX (bbox), 12);
gnome-globalmenu/gtk-modules/macmenu/ige-mac-menu.c:123: return 
gtk_label_get_text
(GTK_LABEL (my_label));
gnome-globalmenu/libgnomenu/patch.sh:10: patch 's;gtk_menu_item_set_submenu
((GtkMenuItem\*) self, NULL);gtk_menu_item_remove_submenu ((GtkMenuItem*) 
self);'
menuitem.c
gnome-globalmenu/libcompat/gtk-fake.h:4: #define 
gtk_widget_set_tooltip_text(widget,
text)
gnome-globalmenu/vapi/gtk+-2.0.vapi:631: [CCode (type = "GtkCellRenderer*",
has_construct_function = false)]
gnome-globalmenu/vapi/gtk+-2.0.vapi:647: [CCode (type = "GtkCellRenderer*",
has_construct_function = false)]
gnome-globalmenu/vapi/gtk+-2.0.vapi:659: [CCode (type = "GtkCellRenderer*",
has_construct_function = false)]
gnome-globalmenu/vapi/gtk+-2.0.vapi:682: [CCode (type = "GtkCellRenderer*",
has_construct_function = false)]
gnome-globalmenu/vapi/gtk+-2.0.vapi:699: [CCode (type = "GtkCellRenderer*",
has_construct_function = false)]
gnome-globalmenu/vapi/gtk+-2.0.vapi:715: [CCode (type = "GtkCellRenderer*",
has_construct_function = false)]
gnome-globalmenu/vapi/gtk+-2.0.vapi:812: [CCode (type = "GtkCellRenderer*",
has_construct_function = false)]
gnome-globalmenu/vapi/gtk+-2.0.vapi:4519: [CCode (type = "GtkTreeModel*",
has_construct_function = false)]
gnome-globalmenu/vapi/gtk+-2.0.vapi:4556: [CCode (type = "GtkTreeModel*",
has_construct_function = false)]
gnome-globalmenu/vapi/gdk-2.0.vapi:262: [CCode (ref_function = "gdk_font_ref",
unref_function = "gdk_font_unref", type_id = "GDK_TYPE_FONT", cheader_filename =
"gdk/gdk.h")]

Original comment by andre.kl...@gmail.com on 6 Aug 2009 at 7:51

GoogleCodeExporter commented 8 years ago
http://blogs.gnome.org/aklapper/2009/08/11/gnome-3-update-module-proposals-welco
me-now/
We need to start moving quickly.

Original comment by pierre.s...@gmail.com on 11 Aug 2009 at 2:00

GoogleCodeExporter commented 8 years ago
Well, it's definitely not required that your code is already perfect before 
applying. :-)
I'm also interested how gnome2-globalmenu works together with gnome-shell. 
Would be
nice if you could mention that in a potential inclusion proposal email.

Original comment by andre.kl...@gmail.com on 13 Aug 2009 at 10:35

GoogleCodeExporter commented 8 years ago

Original comment by pierre.s...@gmail.com on 10 Oct 2009 at 4:38

GoogleCodeExporter commented 8 years ago
Moved to github, as gnome side has no responds. click on Source Tab for details.

Original comment by rainwood...@gmail.com on 10 Oct 2009 at 11:36

GoogleCodeExporter commented 8 years ago
Uhm. Who did you send an email to, and when?

Original comment by andre.kl...@gmail.com on 16 Oct 2009 at 12:46

GoogleCodeExporter commented 8 years ago
We sent the application to the desktop-devel mailing list. There was some 
debate, and
eversince no reply to our last mail.

Original comment by pierre.s...@gmail.com on 16 Oct 2009 at 1:27

GoogleCodeExporter commented 8 years ago
Errm. Where exactly was the request for git.gnome.org? Haven't seen anything 
about that.

And I have only seen one response to all the question asked so far (but I don't 
know
who is part of your developer team so I might be totally wrong here).
Personally I still have no clue how this integrates with gnome-shell for 
example.
Or http://www.mail-archive.com/desktop-devel-list@gnome.org/msg17128.html .

Original comment by andre.kl...@gmail.com on 16 Oct 2009 at 3:08

GoogleCodeExporter commented 8 years ago
http://mail.gnome.org/archives/desktop-devel-list/2009-September/msg00110.html
We sent it a bt late though, so it might be the reason it didn't get any replies
We tried to address and to answer all the questions and concerns that had been 
raised 
or asked.
For the Git Gnome side of thing, it would be more Yu's side ?
Feel free to relaunch the debate on desktop-devel list or here if the mail is 
not 
clear.

Original comment by pierre.s...@gmail.com on 16 Oct 2009 at 5:16

GoogleCodeExporter commented 8 years ago
Yeah, I read that one, but it did not help me a lot, because for me it was that 
you
wrote to people that already know your application.

In general: You proposed something, and people interested had questions and 
feedback.
You answered two weeks later when everybody was already out of the topic, with 
one
email trying to cover everything. From my experience that never works.
I can understand that people were not interesting in spending time to get back 
into
the topic. Answering specific questions in a direct followup email would have 
been cool.

There's a "Module inclusion discussion for 2.30 heats up." soon in the GNOME 
schedule
(release-team's tasks to ask people for opinions again).

Original comment by andre.kl...@gmail.com on 16 Oct 2009 at 7:11

GoogleCodeExporter commented 8 years ago
And still I have not seen any request for using git.gnome.org nowhere - that 
question
still stands.

Original comment by andre.kl...@gmail.com on 16 Oct 2009 at 7:12

GoogleCodeExporter commented 8 years ago
Yup, that's something we screwed on.
Can we still try and answer now to each mail ? Wait for the "heat-up" period ?

For the git.gnome.org, we are definitely willing to move to git.gnome.org. I 
was 
convinced we applied, so I'm checking this with Yu if we have any log of an 
application. Will get back to you very soon on that point.

Original comment by pierre.s...@gmail.com on 18 Oct 2009 at 2:04

GoogleCodeExporter commented 8 years ago
Hmm, good question. What I'd appreciate is an update email - what has been
achieved/changed in the six weeks since you have applied, in general and 
especially
with regard to specific questions or criticism that has been brought up after?

Original comment by andre.kl...@gmail.com on 18 Oct 2009 at 2:27

GoogleCodeExporter commented 8 years ago
I missed the important email sent to me on august 7th from svnmaster and 
achived it
with all other unread mails.

That's the whole progress on the git side. 
Sorry for that. Now that I've digged the mail from dusts and followed the
instructions in the mail. Let's see if there will be progress.

To clearify the personels: 
pierre is the administravite person,
I am the code maintainer,
also several others are helping around the project.

Original comment by rainwood...@gmail.com on 18 Oct 2009 at 7:13

GoogleCodeExporter commented 8 years ago
I assume that you have seen the call for module inclusion discussion heat up on
desktop-devel-list.

Original comment by andre.kl...@gmail.com on 27 Oct 2009 at 12:14

GoogleCodeExporter commented 8 years ago
The git on gnome is up. I donno if it is possible to give others permissions to 
the git. 
Probabily we will use the github one for the development(trunk). I'll 
periodically
pull from there to gnome for a while until we find a solution.

Original comment by rainwood...@gmail.com on 8 Nov 2009 at 11:55

GoogleCodeExporter commented 8 years ago
May we expect any significant changes here? I don't see any changes last time, 
besides a fixed DOAP file half a year ago. I assume the goal to make it a part 
of GNOME (within gnome-shell or gnome-panel or even both) rests in peace.

Original comment by mario.bl...@gmail.com on 5 Jun 2011 at 11:48