search

imsory / gnome2-globalmenu

Automatically exported from code.google.com/p/gnome2-globalmenu
GNU General Public License v2.0
0 stars 0 forks source link

Strange menu gap in some apps on Gnome3 #676

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
See attached screenshots.  In most applications, there is a gap where the app 
menu used to be.   This is using the latest gnome-3 branch.

Original issue reported on code.google.com by bendavi...@gmail.com on 30 Oct 2011 at 10:00

Attachments:

GoogleCodeExporter commented 8 years ago 
the same here.

Original comment by renerpa...@gmail.com on 31 Oct 2011 at 12:39

GoogleCodeExporter commented 8 years ago 
There is a fix for this:

Under /gtk-menubar.vala change lines 73 and 74 from: natural = 10 and minimal = 
10 to natural = 0 and minimal = 0. Can you, the Global Menu guys, please push 
this fix? Thanks!

Original comment by nilarimo...@gmail.com on 7 Dec 2011 at 7:07

GoogleCodeExporter commented 8 years ago 
Last time I did set the height to zero. GTK3 started to issue warnings like 
crazy every time a window is resized; the warnings will be written to 
.xsession-errors on some systems and gradually fill up the harddrive. 

10 is the minimal that won't trigger those warnings. 

Do you get these warnings when make this change and run a program from 
commandline?

Original comment by rainwood...@gmail.com on 7 Dec 2011 at 9:25

GoogleCodeExporter commented 8 years ago 
Yes, I get warnings, but not a huge amount...

Original comment by nilarimo...@gmail.com on 8 Dec 2011 at 12:26

GoogleCodeExporter commented 8 years ago 
Take care, it seems these warnings can sometimes lead to segfault.

I investigated the GTK code. When GTK calculates the height (or width) of the 
menubar, it takes the requested height, and it subtracts the margins defined by 
the theme. So, if you request a height of 0 pixel, you get (that's an example) :
0 - 5 = -5px. Sure, it is a wrong size for a menubar.

The easy way to fix this is to overload the theme. Create the file 
$HOME/.config/gtk-3.0/gtk.css with this content :

.menubar .menuitem {
    padding: 0;
}

Now, you can put 0 in gtk-menubar.vala with no warnings.

Original comment by rom...@ledisez.net on 10 Dec 2011 at 8:23

GoogleCodeExporter commented 8 years ago 
Im wondering if it is possible to override the default theme css in the GTK 
module, or just modify them for the particular menu itme widget created.

Original comment by rainwood...@gmail.com on 11 Dec 2011 at 5:49

GoogleCodeExporter commented 8 years ago 
I have the same issue, but i haven't really understood how to fix this, is 
gtk-menubar.vala a file? if so i can't find it anywhere

Original comment by gramaz...@gmail.com on 9 Jan 2012 at 3:42

GoogleCodeExporter commented 8 years ago 
gtk-menubar.vala is in the gnome-globalmenu source code.  I tried editing 
myself and recompiling/reinstalling, but it didn't seem to fix it for me.

Original comment by bendavi...@gmail.com on 12 Jan 2012 at 4:47

GoogleCodeExporter commented 8 years ago 
https://github.com/gnome-globalmenu/gnome-globalmenu/blob/gnome-3/src/gtk-menuba
r.vala#L73

This is the line I suspect you shall change. make both 0.

Original comment by rainwood...@gmail.com on 12 Jan 2012 at 6:44

GoogleCodeExporter commented 8 years ago 
Yes, that's the change I made, but it didn't seem to fix anything.

Original comment by bendavi...@gmail.com on 12 Jan 2012 at 6:49

GoogleCodeExporter commented 8 years ago 
Scratch that last comment.  I've since rebooted and it now seems to be working 
correctly.

Original comment by bendavi...@gmail.com on 13 Jan 2012 at 11:08

GoogleCodeExporter commented 8 years ago 
stop post simmilar issues becouse of is dificult to find solutions in comments
issue 675

Original comment by oddgh...@mail.ru on 1 Feb 2012 at 6:55