search

imsweb / algorithms

Java implementation of cancer-related algorithms (NHIA, NAPIIA, Survival Time, etc...)
Other
6 stars 6 forks source link

Review why dependencies are listed as implementation instead of api #149

Closed depryf closed 2 years ago

depryf commented 2 years ago

Listing them as implementation means we expect other projects to have to directly use those other libraries. But I don't think that's the case. I think this is an oversight, and those should have all been made API.

depryf commented 2 years ago

Actually, I got this inverted. API means the dependency is exposed, implementation means it's only used in the implementation of this library.

I think the dependencies are properly setup.