search

imsweb / algorithms

Java implementation of cancer-related algorithms (NHIA, NAPIIA, Survival Time, etc...)
Other
6 stars 6 forks source link

Change to the SEER Historic Stage algorithm #46

Closed flynngr closed 6 years ago

flynngr commented 6 years ago

Fixes #45.

depryf commented 6 years ago

@flynngr the changes look good. I saw a few minor formatting issues in the test file, but that's not a big deal.

One thing though: can you please add an entry for you changes in the CHANGELOG.md file? Just check the VERSION file to know the current version (minus the -SNAPSHOT), and then either add to the section for that version if it already exists, or create a new one if it doesn't. Please use a one-line simple description of our changes, no need to be too exhaustive there.

Thanks.

flynngr commented 6 years ago

@depryf - I changed those and pushed. Do I do I do a new pull request?

depryf commented 6 years ago

Nope, no need of a new pull request. This looks good now and I am merging it. If you need this soon, then let me know and I will make a release of the library; otherwise these changes will be available the next time the library is released.

flynngr commented 6 years ago

I think that the next release will be fine. After 11/1 is best to not alarm the registries during submission -- the effect on their DQPs would be minimal so no need to incorporate.

depryf commented 6 years ago

Good. There are a few more issues opened for this library and I would like to resolve some of them before making another release...